-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dibs Payment Service added http://www.dibspayment.com/ #697
Conversation
…utions in Nordern Europe. We have more than a decade of experience
…ions in Northern Europe, has completed a comprehensive survey of e-commerce in selected major European countries
Yes, it is |
With second attempt I have all builds passed exept one : https://travis-ci.org/Shopify/active_merchant/jobs/7221393 |
No, that's a Travis error - you can ignore it. And in general you don't have to open a new Pull Request; you can just push more commits to the branch and the PR will automatically update. |
|
||
# create_ticket() performs a credit- and debit-card check | ||
# and saves the credit card information for recurring payments | ||
def create_ticket(creditcard, options = {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard name for this in ActiveMerchant is store
; see the Paymill and Quickpay gateways for good examples of the expected API.
This looks like a great start, but in addition to my comments inline, there's still a bunch of issues to address:
Let me know if you have any questions as you work on it - thanks! |
@ntalbott DIBS do not have a sandbox so when you do remote tests you will actually spam your active account.....uch.......not ideal for a CI. We built a Spree gateway based on this branch (i have forked it so its frozen). As @maxwhite says in the commit msg, "its huge in Scandinavia" -but I think its a shame that it has such a outdated API ...I hope DIBS hear this and hire some Palo Alto developers ;) |
Thanks for review and comments. I will fix these issues. About the remote tests DIBS does not have test account that can be used for remote testing, thats why I had not included remote tests. Is it possible to do contribution without remote tests ? |
DIBS Payment Services, the largest provider of Internet payment solutions in Northern Europe, has completed a comprehensive survey of e-commerce in selected major European countries