[Sc 65261] Migrate to Vue 3 #108
Conversation
|
This pull request has been linked to Shortcut Story #65261: TrustedForm v4 - Insights Add-On UI should prompt for required and forbidden scan text. |
- This avoids a new error from Vuex 4 which complains when a requested action doesn't exist. The error was being thrown from here https://github.com/activeprospect/integration-components/blob/00ffa7ebba2f93295677abd9cd7cf20d9dbc31ce/src/components/LoadingScreen.vue#L38-L40 and I have no idea why this code exists so I didn't feel comfortable removing it
| @@ -19,7 +19,7 @@ | |||
| <Navigation :onConfirm="onConfirm"/> | |||
| </div> | |||
| <div v-else-if="!isDataService"> | |||
| <LoadingScreen :module-name="'TrustedForm ' + moduleName"/> | |||
| <LoadingScreen :onFinish="() => {/* NOOP */}" :module-name="'TrustedForm ' + moduleName"/> | |||
There was a problem hiding this comment.
This avoids a new error from Vuex 4 which complains when a requested action doesn't exist. The error was being thrown from here and I have no idea why this code exists so I didn't feel comfortable removing it
| @@ -1,20 +1,16 @@ | |||
| import ui from 'leadconduit-integration-ui'; | |||
| import Vue from 'vue'; | |||
| import { createApp } from 'vue'; | |||
There was a problem hiding this comment.
this is not how lc-client instantiates the app, even though it is Vue 3. The way lc-client gets around this is with the @vue/compat lib, which treats things as if they were still Vue 2. Since integrations are such simple micro-apps, I think it makes more sense to "do it right" from the start and use the newer Vue 3 APIs.
| @@ -1,20 +1,16 @@ | |||
| import ui from 'leadconduit-integration-ui'; | |||
| import Vue from 'vue'; | |||
| import { createApp } from 'vue'; | |||
Description of the change
ui-componentslibrary (this was the whole reason to update to Vue 3)Companion PRs:
Testing
This integration is fully functional in this state, you can clone and
npm linkit and test it locally. There are currently no functional changes, the only work of this PR is to update it to Vue 3.Future work
Type of change
Related tickets
https://app.shortcut.com/active-prospect/story/65261/trustedform-v4-insights-add-on-ui-should-prompt-for-required-and-forbidden-scan-text
Checklists
Development and Testing
Code Review
Tracking
QA