Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sc 65261] Migrate to Vue 3 #108

Merged
merged 7 commits into from
Feb 5, 2024
Merged

[Sc 65261] Migrate to Vue 3 #108

merged 7 commits into from
Feb 5, 2024

Commits on Jan 31, 2024

  1. Bump to Vue3

    @ericyd
    ericyd committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9637859 View commit details
    Browse the repository at this point in the history

  2. Fix app/store/router creation

    @ericyd
    ericyd committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    44a6546 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Add onFinish prop 

    - This avoids a new error from Vuex 4 which complains when a requested action doesn't exist. The error was being thrown from here https://github.com/activeprospect/integration-components/blob/00ffa7ebba2f93295677abd9cd7cf20d9dbc31ce/src/components/LoadingScreen.vue#L38-L40 and I have no idea why this code exists so I didn't feel comfortable removing it
    @ericyd
    ericyd committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fe1a103 View commit details
    Browse the repository at this point in the history

  2. Install @activeprospect/integration-components v5

    @ericyd
    ericyd committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ce4e043 View commit details
    Browse the repository at this point in the history

  3. Install @activeprospect/integration-dev-dependencies v2

    @ericyd
    ericyd committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7a9de51 View commit details
    Browse the repository at this point in the history

  4. Fix Verify step

    @ericyd
    ericyd committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8eaa0c3 View commit details
    Browse the repository at this point in the history

  5. Install ui-components dependency

    @ericyd
    ericyd committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c319459 View commit details
    Browse the repository at this point in the history