Sc 30945/client dmi partners inc pulled an export #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 97.04% 97.09% +0.05%
==========================================
Files 34 34
Lines 576 586 +10
==========================================
+ Hits 559 569 +10
Misses 17 17
Continue to review full report at Codecov.
|
mikebetts
suggested changes
Nov 9, 2021
lib/index.js
Outdated
| @@ -55,9 +55,15 @@ const mask = function (obj, doMask = false) { | |||
| for (const key in obj) { | |||
| const value = obj[key]; | |||
| if (key === 'valid') { continue; } | |||
| obj[key] = mask(value, (obj.masked != null) || doMask); | |||
| obj[key] = mask(value, (obj.masked != null || obj.masked !== undefined) || doMask); | |||
There was a problem hiding this comment.
I'm confused by this - if obj.masked is an object, won't it always return true and therefore mask despite what the masked value is set to in that object?
There was a problem hiding this comment.
I see what you mean. I'll update to cover when the obj.masked is a rich type.
asedarski
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related tickets
Checklists
Development and Testing
Code Review
Tracking
QA