-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remove_association_no_negative_assoc to config to allow user to… #1123
base: main
Are you sure you want to change the base?
Added remove_association_no_negative_assoc to config to allow user to… #1123
Conversation
… decide if they want to keep the join when using negative predicates. Fix issue where negative predicates with associated_collection does not use the correct primary key for subquery.
I had failing tests when i tried pulling from master without me making any changes. What do i do when that happens? Those checks that fails are the original failing tests i inherited from just forking. |
…he initial query, and put it in the sub query to get the correct joins.
@Doctor06 please try rebasing against |
@Doctor06 Perhaps context has been lost here and you're no longer interested but master branch should be fully green now, so if you could rebase and fix merge conflicts that'd be awesome! |
@Doctor06 we would love to make this one of the changes released with the 3.0.0 release |
This is breaking the Removing from 3.0.0 release.
|
f8fb6e2
to
a02daba
Compare
… decide if they want to keep the join when using negative predicates.
Fix issue where negative predicates with associated_collection does not use the correct primary key for subquery.