Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

A Few Fixes #11

Merged
merged 4 commits into from
May 9, 2013
Merged

A Few Fixes #11

merged 4 commits into from
May 9, 2013

Conversation

aguynamedryan
Copy link

Just saw your talk from 2012 re: activewarehouse-etl and thought I'd fire up your examples. I hit a few small snags and fixed them:

  • Migrated from .rvmrc to .ruby-version
  • Updated the source entry in the Gemfile to avoid a warning from Bundler
  • My git --shortstat seems to be producing different output from what etl/extract.ctl was expecting, so I threw in a few quick regexps to handle the variations. Not elegant, but they work.

Thanks for the great sample code. It's helping me get off the ground pretty quickly.

@thbar
Copy link
Member

thbar commented May 9, 2013

Hello Ryan,

Great! Thanks for watching the talk and giving this a go.

I'm merging your fixes right now, thank you!

-- Thibaut

thbar added a commit that referenced this pull request May 9, 2013
@thbar thbar merged commit 5dea410 into activewarehouse:master May 9, 2013
@aguynamedryan aguynamedryan deleted the fixes branch May 9, 2013 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants