Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for session access from guards #234

Merged
merged 2 commits into from Mar 25, 2022
Merged

add support for session access from guards #234

merged 2 commits into from Mar 25, 2022

Conversation

tglman
Copy link
Contributor

@tglman tglman commented Mar 22, 2022 •
edited

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.

Overview

Add support for session access to the GuardContext so is possible to do:

.guard(guard::fn_guard(|g| {
                    g.get_session() //......
          }))

@robjtede robjtede added A-session Project: actix-session B-semver-minor labels Mar 22, 2022
@tglman
Copy link
Contributor Author

tglman commented Mar 22, 2022

Hi,

I forced push a fix for the failed tests, but the build did not restart automatically, could you re-run the build.

Regards

@tglman tglman force-pushed the master branch 2 times, most recently from 0bcd135 to 609db83 Compare March 22, 2022 18:27
@robjtede robjtede enabled auto-merge (squash) March 25, 2022 18:13
@robjtede robjtede merged commit 4d77e26 into actix:master Mar 25, 2022
@robjtede
Copy link
Member

released with v0.6.2

@tglman
Copy link
Contributor Author

tglman commented Mar 26, 2022

Thanks, for the quick review and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeMathWalker LukeMathWalker LukeMathWalker left review comments

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-session Project: actix-session B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tglman @robjtede @LukeMathWalker