Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set same-site attribute when clearing session cookie #284

Merged
merged 1 commit into from
Sep 11, 2022
Merged

set same-site attribute when clearing session cookie #284

merged 1 commit into from
Sep 11, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Sep 11, 2022 •
edited
Loading

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

fixes #282

@robjtede robjtede added A-session Project: actix-session B-semver-patch labels Sep 11, 2022
@robjtede robjtede requested a review from a team September 11, 2022 18:26
@robjtede robjtede marked this pull request as ready for review September 11, 2022 18:26
@robjtede robjtede merged commit eb3660a into master Sep 11, 2022
@robjtede robjtede deleted the fix-session-samesite branch September 11, 2022 20:11
@brollb brollb mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
A-session Project: actix-session B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

actix-session's cookie SameSite attribute is not being set
2 participants
@robjtede @mitsuhiko