Migrate threadpool to std::future #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
semtexzv
force-pushed
the
std-future-threadpool
branch
2 times, most recently
from
a242109
to
4300996
Compare
semtexzv
force-pushed
the
std-future-threadpool
branch
from
4300996
to
6f2e3d1
Compare
semtexzv
force-pushed
the
std-future-threadpool
branch
from
6f2e3d1
to
b410a5e
Compare
JohnTitor
reviewed
Oct 1, 2019
| type Item = I; | ||
| type Error = BlockingError<E>; | ||
| impl<I> Future for CpuFuture<I> { | ||
| type Output = Result<I,Cancelled>; |
There was a problem hiding this comment.
Suggested change
| type Output = Result<I,Cancelled>; | |
| type Output = Result<I, Cancelled>; |
| Err(err) => Err(BlockingError::Error(err)), | ||
| } | ||
| fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
| let rx = Pin::new(&mut Pin::get_mut(self).rx); |
There was a problem hiding this comment.
Suggested change
| let rx = Pin::new(&mut Pin::get_mut(self).rx); | |
| let rx = Pin::new(&mut Pin::get_mut(self).rx); |
I think this is not affected by readability.
| @@ -19,7 +19,7 @@ path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| derive_more = "0.15" | |||
| futures = "0.1.25" | |||
| futures = { package = "futures-preview", version = "0.3.0-alpha.18" } | |||
There was a problem hiding this comment.
Suggested change
| futures = { package = "futures-preview", version = "0.3.0-alpha.18" } | |
| futures-preview = "0.3.0-alpha.19" |
IMO: futures-preview is more common?
There was a problem hiding this comment.
So, we should use futures 0.3.0 now
There was a problem hiding this comment.
0.3.1 actually is out for a hotfix
|
@semtexzv are you still working on this? Would you mind if I collaborate on this PR (so you'll give me access to your fork), or should I redo it from scratch as a separate PR? |
|
Just note that futures 0.3.0 is out |
3 tasks
|
superseded #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains code to migrate actix-threadpool to std::future, overall progress tracked in #45.