Implement std::error::Error for our custom errors
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
==========================================
- Coverage 47.95% 47.83% -0.13%
==========================================
Files 137 137
Lines 12805 12851 +46
==========================================
+ Hits 6141 6147 +6
- Misses 6664 6704 +40
Continue to review full report at Codecov.
|
|
Looks good! Could you also update changelogs? |
For allowing a more ergonomic use and better integration on the ecosystem, this adds the `std::error::Error` `impl` for our custom errors. We intent to drop this hand made code once `derive_more` finishes the addition of the Error derive support[1]. Until that is available, we need to live with that. 1. JelteF/derive_more#92 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
otavio
force-pushed
the
topic/impl-error-more-types
branch
from
8ca1377
to
146ae4d
Compare
Your update looks great! |
Sure. I added one entry for each changed crate. Let me know if any other change needs to be done. |
|
@JohnTitor @otavio derive_more now features std::Error derivation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For allowing a more ergonomic use and better integration on the
ecosystem, this adds the
std::error::Errorimplfor our customerrors.
We intent to drop this hand made code once
derive_morefinishes theaddition of the Error derive support[1]. Until that is available, we
need to live with that.