Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set data container on default service calls #1452

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

robjtede
Copy link
Member

closes #1450

@robjtede robjtede requested a review from a team April 14, 2020 01:18
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robjtede
Copy link
Member Author

how come codecov hasnt run on this?

@JohnTitor
Copy link
Member

how come codecov hasnt run on this?

Hmm, it's weird, uploading was successful but the bot didn't comment here: https://github.com/actix/actix-web/pull/1452/checks?check_run_id=584354405

Perhaps we should tweak codecov config, let me check it.

@codecov-io
Copy link

Codecov Report

Merging #1452 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   47.78%   47.90%   +0.11%     
==========================================
  Files         137      137              
  Lines       12871    12889      +18     
==========================================
+ Hits         6150     6174      +24     
+ Misses       6721     6715       -6     
Impacted Files Coverage Δ
src/resource.rs 93.72% <100.00%> (+0.33%) ⬆️
src/scope.rs 94.24% <100.00%> (+0.07%) ⬆️
actix-http/src/h1/dispatcher.rs 55.63% <0.00%> (+0.25%) ⬆️
actix-http/src/h1/codec.rs 70.83% <0.00%> (+1.38%) ⬆️
actix-http/src/h1/payload.rs 73.52% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3f722...45e2e40. Read the comment docs.

@JohnTitor
Copy link
Member

Oh, they showed up late to the party.

@JohnTitor JohnTitor merged commit 5b36381 into master Apr 15, 2020
@JohnTitor JohnTitor deleted the fix/default-service-data branch April 15, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scoped default_service cannot access data from same scope
3 participants