-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export actix_rt::main macro #1559
Conversation
I think that makes sense, but would need to update documentation for it. Is there any reason why |
Using |
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
=======================================
Coverage 51.03% 51.03%
=======================================
Files 129 129
Lines 12049 12049
=======================================
Hits 6149 6149
Misses 5900 5900
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Re-exports
actix_rt::main
asactix_web::main
(andactix_rt::test
asactix_web::test_rt
since test is already a module). Also bumps minimum rt version to 1.1.1.Would like to hear thoughts on this. Seems advantageous to remove the requirement for users to add
actix-rt
as a direct dependency. The question gets asked reasonably often of why two deps are needed for the hello world example.