Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export rt in web and add main macro #1575

Merged
merged 2 commits into from
Jun 22, 2020
Merged

re-export rt in web and add main macro #1575

merged 2 commits into from
Jun 22, 2020

Conversation

robjtede
Copy link
Member

I made a mistake in #1559. The new example file compiled but only because actix-rt is still an explicit dependency of actix-web. This PR re-exports the bundled actix-rt as actix_web::rt, thus allowing access to actix_web::rt::System and copies the main macro out of actix-macros, modifying it to use the new re-export.

Also migrated the main lib.rs module doc comment to use the actix_web::main macro as well as some reduced the scope of some clippy lints.

@robjtede robjtede requested review from a team June 21, 2020 21:22
@robjtede robjtede marked this pull request as ready for review June 21, 2020 21:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2020

Codecov Report

Merging #1575 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         122      122           
  Lines       11630    11630           
=======================================
  Hits         6099     6099           
  Misses       5531     5531           
Impacted Files Coverage Δ
src/app.rs 98.99% <ø> (ø)
src/info.rs 92.85% <ø> (ø)
src/lib.rs 68.42% <ø> (ø)
src/middleware/compress.rs 76.27% <ø> (ø)
src/middleware/defaultheaders.rs 85.48% <ø> (ø)
src/route.rs 85.88% <ø> (ø)
src/types/form.rs 77.24% <ø> (ø)
src/types/json.rs 88.71% <ø> (ø)
src/types/payload.rs 81.34% <ø> (ø)
src/middleware/logger.rs 74.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11052f...0173850. Read the comment docs.

Copy link
Contributor

@cetra3 cetra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this change looks fine if it's all working now

@robjtede robjtede merged commit a70e599 into master Jun 22, 2020
@robjtede robjtede deleted the fix/main-macro branch June 22, 2020 19:09
@robjtede robjtede mentioned this pull request Jun 6, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants