Remove a panic in normalize middleware

[maciejhirsz]

PR Type

Big Fix

PR Checklist

• Tests for the changes have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

Fixes a panic that occurred occasionally when using path normalization middleware. If the original path was empty due to a malformed request, parts.path_and_query would be None. Actual panic logged on a live system 🙃:

Oct 29 14:46:09 polkadot-telemetry-0 a1e8ee04ee4a[678]: thread 'actix-rt:worker:2' panicked at 'called `Option::unwrap()` on a `None` value', /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/actix-web-3.1.0/src/middleware/normalize.rs:140:22

[JohnTitor]

Looks reasonable to me 👍

[robjtede]

move to unreleased section

[robjtede]

is it possible to contrive a test for this? whats the exact condition?

[maciejhirsz]

@robjtede unfortunately my server logs couldn't give me a definitive request URL that triggered it, so I weren't able to reproduce it manually, but it was happening frequently enough to warrant me running a patched version of actix-web. From what I gathered by reading code, this fails when the path is missing either the scheme (no http: etc) or is missing a path (/ is fine).

[JohnTitor]

I prefer just to merge this rather than to wait for coming up with a suitable test as this is a general improvement.

@robjtede Thoughts?

[codecov]

Codecov Report

Merging #1762 (09ae9c9) into master (32d59ca) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   53.80%   53.80%           
=======================================
  Files         129      129           
  Lines       12266    12266           
=======================================
  Hits         6600     6600           
  Misses       5666     5666           

Impacted Files	Coverage Δ
src/middleware/normalize.rs	99.30% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d59ca...09ae9c9. Read the comment docs.

[robjtede]

Yep it's a sensible change regardless.

[JohnTitor]

Thanks!