Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to nightly for intra-doc links #1783

Merged
merged 1 commit into from
Nov 9, 2020
Merged

switching to nightly for intra-doc links #1783

merged 1 commit into from
Nov 9, 2020

Conversation

realaravinth
Copy link
Member

PR Type

Bug Fix

Overview

This PR changes upload-doc Github workflow to use nightly Rust tool chain. nightly is required to migrate to intra-doc links.

@robjtede pointed out that intra-doc links are already in use in some parts of the code base but with the usage of stable, we have broken links in master API documentation.

Please see #1781 for more details.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1783 (cf0dc07) into master (9b42333) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
- Coverage   53.82%   53.79%   -0.04%     
==========================================
  Files         129      128       -1     
  Lines       12193    12201       +8     
==========================================
  Hits         6563     6563              
- Misses       5630     5638       +8     
Impacted Files Coverage Δ
actix-http/src/header/common/mod.rs 7.69% <0.00%> (-2.31%) ⬇️
actix-http/src/header/common/etag.rs
actix-http/src/header/common/content_language.rs
actix-http/src/header/common/if_match.rs
actix-http/src/header/common/accept_charset.rs
actix-http/src/header/common/allow.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/if_none_match.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/expires.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b42333...cf0dc07. Read the comment docs.

@robjtede robjtede merged commit 49e945c into actix:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants