use ByteString as container for websocket text message #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
B-semver-major
therealprof
reviewed
Dec 31, 2020
robjtede
force-pushed
the
websocket-bytestring
branch
from
9cd7c2f
to
319e7f2
Compare
robjtede
force-pushed
the
websocket-bytestring
branch
from
319e7f2
to
b9f9b96
Compare
robjtede
force-pushed
the
websocket-bytestring
branch
from
b9f9b96
to
2858e85
Compare
|
LGTM. |
fakeshadow
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Improvement
PR Checklist
Overview
Use
ByteStringas the contained format for websocket text messages so that the underlying memory can be re-used when sending to many clients; eliminating need for more expensive String cloning.Blocked on #1813 for bytestring v1.0 upgrade.
Breaking change to public interface.
Closes #1846.