big clean up and docs improvmenet of types mod #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
force-pushed
the
cleanup-types
branch
from
f35bad5
to
434d8a4
Compare
abonander
added a commit
to abonander/actix-web
that referenced
this pull request
Apr 13, 2021
Upgrading to the beta and this seems to have changed from `3.3.5` but no reason is given in actix#1894 for the change so I presume it was a mistake. The content field of `Json` is still `pub` which supports this conclusion. I recently switched from calling `.into_inner()` to destructuring in the function arguments and it's a lot nicer, especially for singular path arguments such as: ```rust #[get("/user/{id}")] async fn get_user(Path(user_id): Path<Uuid>) -> Option<User> { // ... } ```
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor (Mostly)
PR Checklist
Check your PR fulfills the following:
Overview
Vastly better docs and code quality on all structs in types mod. Couple improvements made along the way.