Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify ConnectionInfo::new #2282

Merged
merged 7 commits into from
Jun 25, 2021
Merged

simplify ConnectionInfo::new #2282

merged 7 commits into from
Jun 25, 2021

Conversation

ibraheemdev
Copy link
Member

@ibraheemdev ibraheemdev commented Jun 22, 2021 •
edited by robjtede
Loading

PR Type

Refactor

PR Checklist

  • tests
  • changelog
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Simplify ConnectionInfo::new and cover spec better + more tests.

@ibraheemdev ibraheemdev requested review from a team June 22, 2021 22:34
@robjtede robjtede added A-web project: actix-web B-semver-norelease change that does not require a release labels Jun 22, 2021
aliemjay
aliemjay approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@aliemjay aliemjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very elegant. Less code and much easier to read.

src/info.rs Outdated Show resolved Hide resolved
@robjtede robjtede requested review from aliemjay and removed request for a team June 25, 2021 16:43
@robjtede robjtede assigned ibraheemdev and unassigned ibraheemdev Jun 25, 2021
@robjtede robjtede added B-semver-patch and removed B-semver-norelease change that does not require a release labels Jun 25, 2021
@robjtede robjtede merged commit 5eba95b into actix:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede left review comments

@aliemjay aliemjay aliemjay approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibraheemdev @robjtede @aliemjay