add connection level data container #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
B-semver-major
robjtede
force-pushed
the
on-connect-fix-2
branch
from
d682935
to
1e30dad
Compare
|
@ibraheemdev Hope it's alright to call you in as someone who reviewed the original PR. |
robjtede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
PR Checklist
Overview
Second attempt to solve #1770 again without introducing unsafe code and fewer API breaks.
An Rc is kept in the dispatcher and cloned into a Request each time one is created for a connection. The API exposes read-only access to this container through request methods
conn_data.See on_connect example for how this changes the API in on_connect use cases.
Supercedes #2327