Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move response extensions out of head #2585

Merged
merged 7 commits into from Jan 19, 2022
Merged

move response extensions out of head #2585

merged 7 commits into from Jan 19, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Jan 15, 2022 •
edited

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

similar to #2487

Moves extensions from ResponseHead to Response. Also standardized on extensions for requests.

@robjtede robjtede added A-http project: actix-http A-web project: actix-web B-semver-major breaking change requiring a major version bump labels Jan 15, 2022
@robjtede robjtede added this to the actix-web v4 milestone Jan 19, 2022
@robjtede robjtede marked this pull request as ready for review January 19, 2022 01:52
@robjtede robjtede merged commit 2ffc21d into master Jan 19, 2022
@robjtede robjtede deleted the res-extensions-split branch January 19, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-http project: actix-http A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
actix-web v4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robjtede