Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extensions from head #2487

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Remove extensions from head #2487

merged 5 commits into from
Dec 8, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Dec 5, 2021 •
edited

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

  • always seemed weird to me
  • requesthead can be clone now
  • and therefore can impl fromrequest
  • also seeing some perf gains

@robjtede robjtede changed the base branch from master to on-connect-fix December 5, 2021 05:34
@robjtede robjtede added this to the actix-web v4 milestone Dec 5, 2021
@robjtede robjtede added A-http project: actix-http B-semver-major breaking change requiring a major version bump labels Dec 5, 2021
@robjtede robjtede marked this pull request as ready for review December 5, 2021 20:47
@fakeshadow
Copy link
Contributor

fakeshadow commented Dec 7, 2021 •
edited

It's in head for caching purpose. Every thread holds up to 128 RequestHead re-use their allocation.
Are you sure this improves perf. From what I see this would likely cause more allocation and potential memory fragmentation.

@robjtede robjtede changed the base branch from on-connect-fix to master December 7, 2021 17:25
@robjtede
Copy link
Member Author

robjtede commented Dec 7, 2021 •
edited

some benches, seems to support removing this from head

%diff in right-hand column are based on p99 latencies

2021-12-07_21 27 24-1823d5fb

@robjtede robjtede requested a review from a team December 7, 2021 21:45
@robjtede robjtede merged commit 7dc034f into master Dec 8, 2021
@robjtede robjtede deleted the remove-extensions-from-head branch December 8, 2021 22:58
@DDtKey DDtKey mentioned this pull request Dec 25, 2021
Closed
@robjtede robjtede mentioned this pull request Dec 27, 2021
Closed
@robjtede robjtede mentioned this pull request Jan 19, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-http project: actix-http B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
actix-web v4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robjtede @fakeshadow