Fix failing test on Windows #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's weird that this test fails in CI as well but still the CI is green. For example, see here: https://github.com/actix/actix-web/actions/runs/4662131549/jobs/8252162245?pr=2996 |
JohnTitor
force-pushed
the
fix-failing-test
branch
from
812e291
to
2b2f191
Compare
JohnTitor
added
A-files
JohnTitor
approved these changes
Jun 23, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Other
PR Checklist
Overview
The test
files::tests::custom_files_listing_rendererwas failing on Windows because it was expecting non-Windows path separators in the body. This is fixed by parsing the body into aPathand comparing that instead of directly comparing strings.