Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Context::new() public (close #490) #491

Merged
merged 2 commits into from Apr 6, 2021

Conversation

idanarye
Copy link
Contributor

@idanarye idanarye commented Apr 5, 2021

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Closes #490

@fakeshadow
Copy link
Contributor

Maybe a short doc example to show how to use this directly to start an actor?

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the below nit and @fakeshadow's comment.

actix/CHANGES.md Outdated Show resolved Hide resolved
actix/CHANGES.md Outdated Show resolved Hide resolved
@JohnTitor JohnTitor merged commit 69be546 into actix:master Apr 6, 2021
@JohnTitor
Copy link
Member

Thanks!

robjtede pushed a commit to Michael-F-Bryan/actix that referenced this pull request Jul 24, 2023
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make Context::new() public
3 participants