Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy related if statements with branch clone #1576

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

riemass
Copy link
Member

@riemass riemass commented Oct 5, 2023

Fixing if statements regarding bugprone-branch-clone.
I've disabled the warnings for further use since it gets in the way a lot.
To avoid merge conflicts, this PR also disables bugprone-forward-declaration-namespace. This complains a lot because of fwd.hpp style headers.
Pulled from #1565.
Relates #1435.

@riemass riemass requested a review from Neverlord October 5, 2023 07:28
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7753180) 66.93% compared to head (9c45785) 66.83%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
- Coverage   66.93%   66.83%   -0.11%     
==========================================
  Files         644      644              
  Lines       27543    27549       +6     
  Branches     2924     2926       +2     
==========================================
- Hits        18437    18411      -26     
- Misses       7613     7641      +28     
- Partials     1493     1497       +4     
Files Coverage Δ
libcaf_core/caf/config_value.hpp 67.94% <ø> (-0.21%) ⬇️
libcaf_core/caf/detail/glob_match.cpp 22.11% <ø> (ø)
...bcaf_core/caf/detail/stringification_inspector.hpp 94.38% <ø> (ø)
libcaf_core/caf/scheduled_actor.cpp 76.35% <100.00%> (+0.04%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riemass riemass changed the title Clean up if statements - clang-tidy Fix clang-tidy related if statements with branch clone Oct 5, 2023
@Neverlord Neverlord merged commit 35f2ce3 into master Oct 5, 2023
10 checks passed
@Neverlord Neverlord deleted the topic/riemass/clang-tidy-if-statements branch October 5, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants