Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more concise C++17 namespace syntax #1729

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Neverlord
Copy link
Member

Just a small nitpick I've found.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6869d05) 70.91% compared to head (e5d0f26) 70.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   70.91%   70.93%   +0.02%     
==========================================
  Files         645      645              
  Lines       27095    27094       -1     
  Branches     2982     2981       -1     
==========================================
+ Hits        19214    19220       +6     
+ Misses       6188     6187       -1     
+ Partials     1693     1687       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@riemass riemass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note, there's a clang-tidy check for this that we could integrate. #1435

@Neverlord
Copy link
Member Author

Just as a note, there's a clang-tidy check for this that we could integrate. #1435

I've played around with clang-tidy yesterday, that's how I found it.

@Neverlord Neverlord merged commit 18a3d13 into master Jan 28, 2024
11 checks passed
@Neverlord Neverlord deleted the topic/neverlord/concat-nested-namespaces branch January 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants