Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding to and from typed actors #324

Merged

Conversation

ufownl
Copy link
Contributor

@ufownl ufownl commented Jul 7, 2015

Relates #319.

@Inet-Jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@Neverlord
Copy link
Member

I think this PR is a start, but it would make sense to grant dynamically-typed actors access to the new delegate functionality as well.

@ufownl
Copy link
Contributor Author

ufownl commented Jul 7, 2015

I have moved delegate into local_actor and added a test for it. Now the dynamically-typed actors can access to the new delegate functionality.

@Neverlord
Copy link
Member

@Inet-Jenkins ok to test

@Neverlord
Copy link
Member

It still misses an overload for delegate(const actor& dest, ...), though.

@ufownl ufownl force-pushed the topic/typed_actors_delegate branch from 04d62f6 to b29e03c Compare July 7, 2015 16:42
@ufownl ufownl force-pushed the topic/typed_actors_delegate branch from b29e03c to eecbf4e Compare July 7, 2015 19:42
@ufownl
Copy link
Contributor Author

ufownl commented Jul 7, 2015

The new solution you offered has been implemented, and the overload for delegate(const actor& dest, ...) also has been added.

@Neverlord Neverlord merged commit eecbf4e into actor-framework:develop Jul 9, 2015
@Neverlord
Copy link
Member

Amazing work, as always. I cleaned up the code a bit and renamed the detail::delegate_helper to delegated. This is because users need to be able to type this name. Also, delegating to a dynamically typed actor returns void (there's really nothing that could be inferred here).

Thanks for contributing to CAF, you rock!

@ufownl ufownl deleted the topic/typed_actors_delegate branch July 10, 2015 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants