Skip to content

Commit

Permalink
refactor: Rename ambi output in Python examples (#2504)
Browse files Browse the repository at this point in the history
`tracks` vs `trajectories`

this might break client python code but should be easy to adopt

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
andiwand and kodiakhq[bot] committed Oct 3, 2023
1 parent 7719ac6 commit 42fca85
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions Examples/Python/python/acts/examples/reconstruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,7 @@ def addAmbiguityResolution(
alg = GreedyAmbiguityResolutionAlgorithm(
level=customLogLevel(),
inputTracks="tracks",
outputTracks="filteredTrajectories",
outputTracks="ambiTracks",
**acts.examples.defaultKWArgs(
maximumSharedHits=config.maximumSharedHits,
nMeasurementsMin=config.nMeasurementsMin,
Expand All @@ -1335,7 +1335,7 @@ def addAmbiguityResolution(
trackConverter = acts.examples.TracksToTrajectories(
level=customLogLevel(),
inputTracks=alg.config.outputTracks,
outputTrajectories="trajectories-from-solved-tracks",
outputTrajectories="ambiTrajectories",
)
s.addAlgorithm(trackConverter)
s.addWhiteboardAlias("trajectories", trackConverter.config.outputTrajectories)
Expand Down Expand Up @@ -1379,7 +1379,7 @@ def addAmbiguityResolutionML(
level=customLogLevel(),
inputTracks="tracks",
inputDuplicateNN=onnxModelFile,
outputTracks="filteredTrajectoriesML",
outputTracks="ambiTracksML",
**acts.examples.defaultKWArgs(
nMeasurementsMin=config.nMeasurementsMin,
),
Expand All @@ -1388,7 +1388,7 @@ def addAmbiguityResolutionML(
algGreedy = GreedyAmbiguityResolutionAlgorithm(
level=customLogLevel(),
inputTracks=algML.config.outputTracks,
outputTracks="filteredTrajectoriesMLGreedy",
outputTracks="ambiTracksMLGreedy",
**acts.examples.defaultKWArgs(
maximumSharedHits=config.maximumSharedHits,
nMeasurementsMin=config.nMeasurementsMin,
Expand All @@ -1402,7 +1402,7 @@ def addAmbiguityResolutionML(
trackConverter = acts.examples.TracksToTrajectories(
level=customLogLevel(),
inputTracks=algGreedy.config.outputTracks,
outputTrajectories="trajectories-from-solved-tracks",
outputTrajectories="ambiTrajectories",
)
s.addAlgorithm(trackConverter)
s.addWhiteboardAlias("trajectories", trackConverter.config.outputTrajectories)
Expand Down Expand Up @@ -1444,7 +1444,7 @@ def addAmbiguityResolutionMLDBScan(
level=customLogLevel(),
inputTracks="tracks",
inputDuplicateNN=onnxModelFile,
outputTracks="filteredTrajectoriesMLDBScan",
outputTracks="ambiTracksMLDBScan",
**acts.examples.defaultKWArgs(
nMeasurementsMin=config.nMeasurementsMin,
epsilonDBScan=config.epsilonDBScan,
Expand All @@ -1456,7 +1456,7 @@ def addAmbiguityResolutionMLDBScan(
trackConverter = acts.examples.TracksToTrajectories(
level=customLogLevel(),
inputTracks=alg.config.outputTracks,
outputTrajectories="trajectories-from-solved-tracks",
outputTrajectories="ambiTrajectories",
)
s.addAlgorithm(trackConverter)
s.addWhiteboardAlias("trajectories", trackConverter.config.outputTrajectories)
Expand Down

0 comments on commit 42fca85

Please sign in to comment.