Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add python vertex example + test #1028

Merged
merged 12 commits into from
Jan 10, 2022

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Oct 6, 2021

This test tries to model all the vertexing combinations, where I noticed that some of them don't seem to produce outputs that make sense to me. It might be that some combinations are not supported / never tested, and I added a warning to the example script if such a combination is configured.

Right now this is still WIP because it's rebased on #1027 since it uses the truth tracking for the test

@baschlag could you help and take a look at this to see if this implementation makes sense?

@paulgessinger paulgessinger added this to the next milestone Oct 6, 2021
@paulgessinger paulgessinger added the 🚧 WIP Work-in-progress label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1028 (0cd0f4b) into main (8b0005c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   48.62%   48.62%   -0.01%     
==========================================
  Files         341      341              
  Lines       17511    17512       +1     
  Branches     8244     8245       +1     
==========================================
  Hits         8515     8515              
- Misses       3232     3233       +1     
  Partials     5764     5764              
Impacted Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 42.04% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0005c...0cd0f4b. Read the comment docs.

@stale
Copy link

stale bot commented Nov 18, 2021

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Nov 18, 2021
@paulgessinger
Copy link
Member Author

@Corentin-Allaire this is what I was talking about this morning.

@stale stale bot removed the Stale label Nov 22, 2021
@Corentin-Allaire
Copy link
Contributor

@Corentin-Allaire this is what I was talking about this morning.

@paulgessinger I can cross-check it with the how to and try to run it. I guess for now that will be good enough until either someone with more vertexing knowledge can look at it or someone need to run it and can provide feedback.
I will try to take care of that before tomorrows meeting

@paulgessinger
Copy link
Member Author

@Corentin-Allaire sounds good!

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have a few comments on the PR. I am obviously not a big vertexing expert but I think this can go in.

Examples/Scripts/Python/truth_tracking.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/truth_tracking.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/vertex_fitting.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/vertex_fitting.py Outdated Show resolved Hide resolved
Examples/Python/tests/test_examples.py Show resolved Hide resolved
@paulgessinger
Copy link
Member Author

paulgessinger commented Nov 29, 2021

I updated this. Unfortunately, I got an error when actually increasing the number of events the test runs on. In the AMVF variant with particle input, on the 59th event, AMVF complains that an empty input is provided. IVF does not seem to have a problem with that event it seems.

13:30:44    AdaptiveMult   ERROR     Error in vertex finder: Empty input provided.

There is still the case of the summary writer complaining that the truth particles are mismatched w.r.t. to the reconstructed tracks. I guess this expected if we don't reconstruct a truth particle?

13:30:44    RootVertexPe   INFO      Total number of generated truth particles in event : 2
13:30:44    RootVertexPe   INFO      Total number of generated truth primary vertices : 1
13:30:44    RootVertexPe   INFO      Total number of selected truth particles in event : 2
13:30:44    RootVertexPe   INFO      Total number of detector-accepted truth primary vertices : 1
13:30:44    RootVertexPe   INFO      Total number of reco track-associated truth particles in event : 2
13:30:44    RootVertexPe   INFO      Total number of reco track-associated truth primary vertices : 1
13:30:44    RootVertexPe   INFO      Total number of reconstructed tracks : 1
13:30:44    RootVertexPe   WARNING   Number of fitted tracks and associated truth particles do not match. Not able to match fitted tracks at reconstructed vertex to truth vertex.

@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label Nov 30, 2021
@paulgessinger
Copy link
Member Author

Ah yeah, the cases I mentioned in the previous comment is actually a WARNING, which we disallow in the CI.

Any opinions on what we should do here?

@paulgessinger
Copy link
Member Author

I created #1091 to track the issues that remain with the code added here.

@stale
Copy link

stale bot commented Jan 7, 2022

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Jan 7, 2022
@Corentin-Allaire
Copy link
Contributor

You should resolved the conversations.

@stale stale bot removed the Stale label Jan 10, 2022
@paulgessinger
Copy link
Member Author

Ok I think it's all green now. Can you approve again if you're happy, @Corentin-Allaire?

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to close the last issue !

@kodiakhq kodiakhq bot merged commit 5e7485b into acts-project:main Jan 10, 2022
@paulgessinger paulgessinger deleted the python-vertex-example branch January 10, 2022 15:50
@paulgessinger paulgessinger modified the milestones: next, v16.0.0 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants