Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tell Stale bot to only mark as stale, but not close #1053

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Oct 27, 2021

Since we're down to about 25 issues open right now, I think we could try switching off auto-closing of stale issues by the bot. With this configuration, it would still mark issues/PRs as stale after 30 days, but not close them. In combination with this I would also remove the exemption for labels Bug and Long Term, which should be fine to label as stale but won't be closed anyway with this configuration.

Since we're down to about 25 issues open right now, I think we could try switching off auto-closing of stale issues by the bot. With this configuration, it would still mark issues/PRs as stale after 30 days, but not close them. In combination with this I would also remove the exemption for labels `Bug` and `Long Term`, which should be fine to label as stale but won't be closed anyway with this configuration.

Thoughts?
@paulgessinger paulgessinger added this to the next milestone Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1053 (84b58ed) into main (8831a88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1053   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files         338      338           
  Lines       17369    17369           
  Branches     8216     8216           
=======================================
  Hits         8437     8437           
  Misses       3179     3179           
  Partials     5753     5753           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831a88...84b58ed. Read the comment docs.

Copy link
Contributor

@HadrienG2 HadrienG2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@kodiakhq kodiakhq bot merged commit ba770f0 into acts-project:main Nov 2, 2021
@paulgessinger paulgessinger deleted the ci/stale-no-close branch November 3, 2021 08:11
@paulgessinger paulgessinger modified the milestones: next, v15.0.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants