Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor kalman-fitter test so it can be reused for other fitters #1122

Merged

Conversation

benjaminhuth
Copy link
Member

This PR restructures the testing code for the KalmanFitter so that it can be reused for other fitters. This especially targets the GSF, but could also be useful for the GX2F #1099.

This is mainly done by putting the code inside a header file and templating the functions on fitter_t, fitter_options_t and parameters_t.

This should not change the behavior or the results of the tests.

@benjaminhuth benjaminhuth added this to the next milestone Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1122 (4140161) into main (4c3ddcf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   48.62%   48.62%           
=======================================
  Files         341      341           
  Lines       17511    17511           
  Branches     8244     8244           
=======================================
  Hits         8515     8515           
  Misses       3232     3232           
  Partials     5764     5764           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3ddcf...4140161. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's go.

@kodiakhq kodiakhq bot merged commit 8b0005c into acts-project:main Jan 7, 2022
@paulgessinger paulgessinger modified the milestones: next, v16.0.0 Jan 13, 2022
@benjaminhuth benjaminhuth deleted the test/prepare-kf-tests-for-gsf branch February 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants