Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve Python import helpers #1316

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

andiwand
Copy link
Contributor

after my recent changes hepmc3 test will only run if the environment is sourced. this refactors the import helpers in order to fix that

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1316 (75499c2) into main (dfd644d) will not change coverage.
The diff coverage is n/a.

❗ Current head 75499c2 differs from pull request most recent head e348e32. Consider uploading reports for the commit e348e32 to get more accurate results

@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   47.42%   47.42%           
=======================================
  Files         375      375           
  Lines       19788    19788           
  Branches     9287     9287           
=======================================
  Hits         9385     9385           
  Misses       4021     4021           
  Partials     6382     6382           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulgessinger paulgessinger changed the title refactor python import helpers refactor: Improve Python import helpers Jul 11, 2022
@paulgessinger paulgessinger added this to the next milestone Jul 11, 2022
@andiwand
Copy link
Contributor Author

@andiwand
Copy link
Contributor Author

good to go @paulgessinger ?

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge if the CI runs through now without skipped tests.

@kodiakhq kodiakhq bot merged commit 0717e5b into acts-project:main Jul 12, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.5.0 Jul 25, 2022
@andiwand andiwand deleted the refactor-python-import-helpers branch October 26, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants