feat: don't use TBB in Sequence(numThreads=1) #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1444 +/- ##
=======================================
Coverage 48.59% 48.59%
=======================================
Files 380 380
Lines 20589 20589
Branches 9431 9431
=======================================
Hits 10005 10005
Misses 4097 4097
Partials 6487 6487 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HadrienG2
suggested changes
Aug 18, 2022
added 6 commits
August 18, 2022 16:48
…s lambda for each event, rather than letting the lamda do the whole thing. This is closer to what tbb does.
HadrienG2
approved these changes
Aug 19, 2022
paulgessinger
requested changes
Aug 19, 2022
I added |
paulgessinger
approved these changes
Aug 19, 2022
paulgessinger
added
automerge
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Let's the `Sequencer` bypass the Intel TBB library if `numThreads=1`. * This could simplify debugging. * Uses some wrapper functions for most of the TBB functions that we use in `Sequencer`. * Note that only a small subset of TBB functions are implemented, and `tbb::blocked_range` (which doesn't require any thread setup) is still taken from the TBB library. * However, if `NO_TBB` is defined, then don't use TBB library at all (throws an exception unless `numThreads=1` or `-1`). * This should allow the ACTS Examples to be built without the TBB library (and removes one dependency on ROOT). At the moment, this doesn't have any CMake support for disabling linking with the TBB library. If someone thinks this might be useful, please let me know - or add it to this PR! (cherry picked from commit 2171277)
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
…lop/v19.x] (#1449) Backport 2171277 from #1444. --- * Let's the `Sequencer` bypass the Intel TBB library if `numThreads=1`. * This could simplify debugging. * Uses some wrapper functions for most of the TBB functions that we use in `Sequencer`. * Note that only a small subset of TBB functions are implemented, and `tbb::blocked_range` (which doesn't require any thread setup) is still taken from the TBB library. * However, if `NO_TBB` is defined, then don't use TBB library at all (throws an exception unless `numThreads=1` or `-1`). * This should allow the ACTS Examples to be built without the TBB library (and removes one dependency on ROOT). At the moment, this doesn't have any CMake support for disabling linking with the TBB library. If someone thinks this might be useful, please let me know - or add it to this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequencerbypass the Intel TBB library ifnumThreads=1.Sequencer.tbb::blocked_range(which doesn't require any thread setup) is still taken from the TBB library.NO_TBBis defined, then don't use TBB library at all (throws an exception unlessnumThreads=1or-1).At the moment, this doesn't have any CMake support for disabling linking with the TBB library. If someone thinks this might be useful, please let me know - or add it to this PR!