-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align amvf config with athena #1723
feat: align amvf config with athena #1723
Conversation
I guess this is bad because the unit tests couple to the default values. might be better to overwrite the options in the examples? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I also rechecked the values (y)
📊 Physics performance monitoring for fe912b3Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
- Coverage 49.20% 49.20% -0.01%
==========================================
Files 398 398
Lines 21853 21849 -4
Branches 9916 9915 -1
==========================================
- Hits 10753 10750 -3
Misses 4222 4222
+ Partials 6878 6877 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@AJPfleger could you take another look? |
config take from https://gitlab.cern.ch/atlas/athena/-/blob/master/Tracking/Acts/ActsTrkTools/ActsTrkPriVtxFinderTool/src/AdaptiveMultiPriVtxFinderTool.h