Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align amvf config with athena #1723

Merged
merged 10 commits into from
Dec 14, 2022

Conversation

@andiwand andiwand added this to the next milestone Dec 8, 2022
@andiwand
Copy link
Contributor Author

andiwand commented Dec 8, 2022

I guess this is bad because the unit tests couple to the default values. might be better to overwrite the options in the examples?

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I also rechecked the values (y)

Core/include/Acts/Utilities/AnnealingUtility.hpp Outdated Show resolved Hide resolved
@andiwand andiwand added the Component - Examples Affects the Examples module label Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Dec 13, 2022

📊 Physics performance monitoring for fe912b3

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1723 (a0d24b2) into main (e73b9a6) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a0d24b2 differs from pull request most recent head fe912b3. Consider uploading reports for the commit fe912b3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
- Coverage   49.20%   49.20%   -0.01%     
==========================================
  Files         398      398              
  Lines       21853    21849       -4     
  Branches     9916     9915       -1     
==========================================
- Hits        10753    10750       -3     
  Misses       4222     4222              
+ Partials     6878     6877       -1     
Impacted Files Coverage Δ
Core/include/Acts/Utilities/AnnealingUtility.hpp 60.00% <ø> (-23.34%) ⬇️
Core/src/Utilities/AnnealingUtility.cpp 100.00% <ø> (ø)
Core/include/Acts/TrackFitting/Chi2Fitter.hpp 35.23% <0.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand
Copy link
Contributor Author

@AJPfleger could you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants