refactor: align Kalman fitter function with GSF fitter function #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
andiwand
commented
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 49.45% 49.44% -0.01%
==========================================
Files 408 408
Lines 22701 22704 +3
Branches 10370 10371 +1
==========================================
Hits 11226 11226
- Misses 4263 4266 +3
Partials 7212 7212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…/acts into refactor-kalman-fitter-function
📊 Physics performance monitoring for d630df5Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
benjaminhuth
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kalman fitter function was missing some features the GSF fitter already has