Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RootMeasurementWriter std vs var #1890

Merged

Conversation

andiwand
Copy link
Contributor

variance was filled with standard deviation in the RootMeasurementWriter

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 22, 2023
@andiwand andiwand added this to the next milestone Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1890 (c27841c) into main (0e57ea9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         408      408           
  Lines       22701    22701           
  Branches    10370    10370           
=======================================
  Hits        11226    11226           
  Misses       4263     4263           
  Partials     7212     7212           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

📊 Physics performance monitoring for c27841c

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@asalzburger
Copy link
Contributor

This will need an update of the reference histograms then, right ?

@kodiakhq kodiakhq bot merged commit 0d9f51b into acts-project:main Feb 23, 2023
@andiwand andiwand deleted the fix-root-measurement-writer-var-vs-std branch February 23, 2023 10:38
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants