Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logger to multi stepper #1964

Merged
merged 7 commits into from
Apr 12, 2023

Conversation

benjaminhuth
Copy link
Member

Adds a logger to the Acts::MultiEigenStepperLoop in order to see again the log messages from the step(...) function.

@benjaminhuth benjaminhuth added Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature labels Mar 19, 2023
@benjaminhuth benjaminhuth added this to the next milestone Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1964 (eff7c4e) into main (fcdc820) will decrease coverage by 0.20%.
The diff coverage is 87.50%.

❗ Current head eff7c4e differs from pull request most recent head 00df126. Consider uploading reports for the commit 00df126 to get more accurate results

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   49.81%   49.62%   -0.20%     
==========================================
  Files         421      410      -11     
  Lines       23876    23303     -573     
  Branches    10836    10630     -206     
==========================================
- Hits        11895    11563     -332     
+ Misses       4366     4292      -74     
+ Partials     7615     7448     -167     
Impacted Files Coverage Δ
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp 72.04% <85.71%> (+1.93%) ⬆️
.../include/Acts/Propagator/MultiEigenStepperLoop.ipp 37.00% <100.00%> (+0.78%) ⬆️

... and 70 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 19, 2023

📊 Physics performance monitoring for 00df126

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kodiakhq kodiakhq bot merged commit 6e35712 into acts-project:main Apr 12, 2023
36 checks passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
@benjaminhuth benjaminhuth deleted the feature/multi-stepper-logger branch May 10, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants