Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MultiTrajectory parameters and covariance constness #2009

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

paulgessinger
Copy link
Member

I believe these functions were not fully usable before if used through a const MultiTrajectory.

@paulgessinger paulgessinger added this to the next milestone Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2009 (36dc19d) into main (ff07dd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         415      415           
  Lines       23593    23593           
  Branches    10681    10681           
=======================================
  Hits        11758    11758           
  Misses       4330     4330           
  Partials     7505     7505           
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 70.97% <ø> (ø)
Core/include/Acts/EventData/MultiTrajectory.ipp 52.94% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

📊 Physics performance monitoring for 36dc19d

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@benjaminhuth benjaminhuth added Component - Core Affects the Core module automerge labels Apr 5, 2023
@kodiakhq kodiakhq bot merged commit 76e9db6 into acts-project:main Apr 5, 2023
37 checks passed
@github-actions github-actions bot removed the automerge label Apr 5, 2023
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants