refactor: Adding time to HelicalTrackLinearizer

[felix-russo]

In this PR the derivatives of/wrt time are added to the Jacobians computed in HelicalTrackLinearizer. The terms have been checked by comparing them to numerically computed derivatives (see PR #2141).

Here is a PDF where the Jacobians are derived: Track_Linearization.pdf.
Note that nobody (except me) read this yet, so it might have some mistakes in it. Any feedback is more than welcome!

Something that might need discussion: To compute the new terms, we need to have a mass and a charge hypothesis of the tracks. Right now, Pion mass and unit charge are assumed in the code, but it might be worth adding specific hypotheses to the track objects.

[codecov]

Codecov Report

Merging #2179 (e036771) into main (ac31a9b) will increase coverage by 0.00%.
The diff coverage is 30.15%.

@@           Coverage Diff           @@
##             main    #2179   +/-   ##
=======================================
  Coverage   49.52%   49.52%           
=======================================
  Files         453      453           
  Lines       25677    25691   +14     
  Branches    11815    11819    +4     
=======================================
+ Hits        12716    12723    +7     
- Misses       4583     4585    +2     
- Partials     8378     8383    +5     

Files Changed	Coverage Δ
.../include/Acts/Vertexing/HelicalTrackLinearizer.hpp	100.00% <ø> (ø)
...nclude/Acts/Vertexing/NumericalTrackLinearizer.ipp	13.55% <0.00%> (-2.81%)	⬇️
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp	26.13% <32.20%> (+6.90%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for e036771

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[AJPfleger]

Could it make sense to add the derivation on overleaf as some screenshots to the PR description?

[pbutti]

@andiwand what's the status of merging this in?
@felix-russo Next step is to implement a test to check the FullBilloirFit. what about porting this? https://github.com/pbutti/acts/blob/pf_4dvtx/Tests/UnitTests/Core/Vertexing/FullBilloirVertexFitterTests.cpp

Invalidated by push of 4002e83

[paulgessinger]

I manually launched an Athena CI run here: https://gitlab.cern.ch/acts/acts-athena-ci/-/pipelines/6020912

[felix-russo]

No large differences in athena expected, see athena-ci.zip

[felix-russo]

Thanks to @andiwand's stabilization of the AMVF, these changes only have an impact on the IVF (where we don't exclude the time during the vertex fit by using head statements).

[paulgessinger]

Let's gamble, try merging.

[acts-project-service]

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🔴	run_workflow_tests_run2_data
🔴	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data