Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Drop bool conversion in favor of isAlive method in Fatras::Particle #2266

Merged
merged 1 commit into from
Jul 4, 2023
Merged

refactor: Drop bool conversion in favor of isAlive method in Fatras::Particle #2266

merged 1 commit into from
Jul 4, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 4, 2023

Makes the state check for the particle more explicit

@andiwand andiwand added the Component - Fatras Affects the Fatras module label Jul 4, 2023
@andiwand andiwand added this to the next milestone Jul 4, 2023
@andiwand andiwand mentioned this pull request Jul 4, 2023
Merged
paulgessinger
paulgessinger approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@paulgessinger paulgessinger mentioned this pull request Jul 4, 2023
Merged
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited

Codecov Report

Merging #2266 (dd4a92f) into main (0c906ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2266   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         449      449           
  Lines       25408    25408           
  Branches    11724    11724           
=======================================
  Hits        12521    12521           
  Misses       4554     4554           
  Partials     8333     8333

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

📊 Physics performance monitoring for dd4a92f

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit af748f6 into acts-project:main Jul 4, 2023
56 checks passed
@github-actions github-actions bot removed the automerge label Jul 4, 2023
@andiwand andiwand deleted the refactor-fatras-particle-isalive branch July 4, 2023 11:19
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 4, 2023 •
edited

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsTrkSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

kodiakhq bot pushed a commit that referenced this pull request Jul 5, 2023
@andiwand
feat: Add ability to remove secondaries in ParticleSelector (#2265)
ccbed15 
Allows to filter secondary particles with `ParticleSelector`

blocked by
- #2266
kodiakhq bot pushed a commit that referenced this pull request Jul 6, 2023
@andiwand
ci: Physmon for event simulation (#2232)
b513232 
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4.

The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation.

Possible improvements:
- record deltas for momenta / eta / phi and so on instead of initial and final

Blocked by
- #2241
- #2260
- #2262
- #2263
- #2264
- #2265
- #2266
@paulgessinger paulgessinger modified the milestones: next, v27.2.0 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Component - Fatras Affects the Fatras module Event Data Model
Projects
None yet
Milestone
v27.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andiwand @acts-project-service @paulgessinger