fix: Fix FPEOVF in RootParticleWriter
#2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
approved these changes
Jun 23, 2023
|
I was not sure why this occurred. Maybe G4 produces a max double in some cases. I will do the float wrapping tho so I do not have to change the reference |
📊 Physics performance monitoring for 950f575Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 49.35% 49.35%
=======================================
Files 445 445
Lines 25264 25264
Branches 11650 11650
=======================================
Hits 12468 12468
Misses 4512 4512
Partials 8284 8284 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@paulgessinger can you re-approve? |
noemina
pushed a commit
to noemina/acts
that referenced
this pull request
Jul 5, 2023
I run into a few occasions where `float -> double` caused an FPEOVF. In this PR I change the output precision accordingly. Discovered in acts-project#2232 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4. The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation. Possible improvements: - record deltas for momenta / eta / phi and so on instead of initial and final Blocked by - #2241 - #2260 - #2262 - #2263 - #2264 - #2265 - #2266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into a few occasions where
float -> doublecaused an FPEOVF. In this PR I change the output precision accordingly.Discovered in #2232