Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove potential FPE in RootTrajectorySummaryWriter #2260

Merged
merged 5 commits into from
Jul 5, 2023
Merged

fix: Remove potential FPE in RootTrajectorySummaryWriter #2260

merged 5 commits into from
Jul 5, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 4, 2023

NAN default values are evil

@andiwand andiwand added the Component - Examples Affects the Examples module label Jul 4, 2023
@andiwand andiwand added this to the next milestone Jul 4, 2023
@andiwand andiwand mentioned this pull request Jul 4, 2023
Merged
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #2260 (a3855c8) into main (598ae96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2260   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         450      450           
  Lines       25410    25410           
  Branches    11724    11724           
=======================================
  Hits        12521    12521           
  Misses       4556     4556           
  Partials     8333     8333

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand
Copy link
Contributor Author

andiwand commented Jul 4, 2023

I do not expect any hash changes. Lets see if this is fixed now

@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

📊 Physics performance monitoring for a3855c8

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand mentioned this pull request Jul 5, 2023
Merged
@kodiakhq kodiakhq bot merged commit f118922 into acts-project:main Jul 5, 2023
51 of 52 checks passed
@andiwand andiwand deleted the fix-fpe-root-trajsum-writer branch July 5, 2023 12:34
@github-actions github-actions bot removed the automerge label Jul 5, 2023
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 5, 2023 •
edited
Loading

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsTrkSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 5, 2023
@paulgessinger
Copy link
Member

paulgessinger commented Jul 5, 2023 •
edited
Loading

@acts-project-service I think this is due to the recent renaming of Athena master to main, which I have to fix.

EDIT: Fixed now.

@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Jul 5, 2023
kodiakhq bot pushed a commit that referenced this pull request Jul 5, 2023
@andiwand
fix: Fix some Geant4<->Acts unit conversions (#2264)
0ad1e47 
Adds missing mass and time conversion factors

blocked by
- #2260
kodiakhq bot pushed a commit that referenced this pull request Jul 6, 2023
@andiwand
ci: Physmon for event simulation (#2232)
b513232 
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4.

The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation.

Possible improvements:
- record deltas for momenta / eta / phi and so on instead of initial and final

Blocked by
- #2241
- #2260
- #2262
- #2263
- #2264
- #2265
- #2266
@paulgessinger paulgessinger modified the milestones: next, v27.2.0 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v27.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andiwand @acts-project-service @paulgessinger