fix: Generic Detector negative strip endcap rotation

[paulgessinger]

Sensors were flipped along local z, meaning they are the wrong way around.

[github-actions]

📊: Physics performance monitoring for 14900ec

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[codecov]

Codecov Report

Merging #2358 (14900ec) into main (a872842) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   49.69%   49.69%           
=======================================
  Files         454      454           
  Lines       25809    25809           
  Branches    11852    11852           
=======================================
  Hits        12825    12825           
  Misses       4581     4581           
  Partials     8403     8403           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[paulgessinger]

As expected, physmon is happy but a lot of hashes change.

Invalidated by push of 086129c

[andiwand]

I fear we also need some updates in test_digitization_example - there are hardcoded volumes and layers

[paulgessinger]

@andiwand That's confusing actually. Does this change the module numbers maybe?

[niermann999]

@andiwand That's confusing actually. Does this change the module numbers maybe?

The modules will be placed at different phi values in the same ring, I think

[andiwand]

If I understand this correctly the geoid should be the same no? because we only rotate/flip the modules

but we might hit them differently because of the geometry change which might cause this test to fail

[paulgessinger]

Does this rotate the module about the center of the disk and not the module center? Or why would the phi values changes?

[niermann999]

Nothing is rotated compared to the previous version. The translation was such that a correctly rotated modules was placed on the wrong side of the disc (mirrored at the origin compared to the positive endcap) thus effectively flipping it. If this becomes a problem with the module numbers, then we have to solve it indeed by changing the rotation instead of the translation and flip the modules instead of placing them differently, but that would make the code less intuitive, I thought

[paulgessinger]

Why does this keep flip-flopping between failed hashes and conflicts in the hash file 😠

[paulgessinger]

/run-experiment atlas

[acts-project-service]

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🔴	run_workflow_tests_run4_mc
🔴	run_workflow_tests_run2_mc
🔴	run_workflow_tests_run2_data
🔴	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data