Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent debug printout crashing Python TGeoDetector.create() #1254

Merged
merged 3 commits into from May 17, 2022
Merged

fix: prevent debug printout crashing Python TGeoDetector.create() #1254

merged 3 commits into from May 17, 2022

Conversation

timadye
Copy link
Contributor

@timadye timadye commented May 13, 2022

  • Prevent dump_args_calls from instrumenting Interval and screwing up TGeoDetector.create()
  • Add a couple of commented-out options to full_chain_itk.py:
    • show different seeding options
    • add dump_args_calls to debug Python bindings

Tim Adye added 2 commits May 13, 2022 20:51
@timadye timadye added this to the next milestone May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022 •
edited

Codecov Report

Merging #1254 (d346f07) into main (de23d56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files         375      375           
  Lines       19588    19588           
  Branches     9214     9214           
=======================================
  Hits         9382     9382           
  Misses       3822     3822           
  Partials     6384     6384

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

paulgessinger
paulgessinger approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulgessinger paulgessinger added Component - Examples Affects the Examples module automerge labels May 17, 2022
@kodiakhq kodiakhq bot merged commit 6ca91a3 into acts-project:main May 17, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
automerge Component - Examples Affects the Examples module
Projects
None yet
Milestone
v19.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timadye @paulgessinger