Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling, grammar, (image-)links; unify reccuring expressions #1259

Merged
merged 6 commits into from May 17, 2022

Conversation

AJPfleger
Copy link
Contributor

I fixed mainly those things I stumbled over during my first days, since some of them caused a little confusion for me.

  • spelling/grammar/typos
  • missing images links: the relative links were pointing to the wrong layer
  • updated link to Pythia8: they changed their website
  • missing expressions in commands

I unified some expressions:

  • DD4hep instead of DD4Hep
  • and instead of <build_dir>, , , ...
  • multiline cmake expressions for the terminal

@AJPfleger AJPfleger added the Component - Documentation Affects the documentation label May 17, 2022
@AJPfleger AJPfleger added this to the next milestone May 17, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1259 (50f9d46) into main (6ca91a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files         375      375           
  Lines       19588    19588           
  Branches     9214     9214           
=======================================
  Hits         9382     9382           
  Misses       3822     3822           
  Partials     6384     6384           
Impacted Files Coverage Δ
Core/include/Acts/Definitions/Common.hpp 92.30% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp 68.42% <ø> (ø)
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp 70.37% <ø> (ø)
...re/include/Acts/Propagator/StraightLineStepper.hpp 67.85% <ø> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 45.07% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kodiakhq kodiakhq bot merged commit 9ddf828 into acts-project:main May 17, 2022
@AJPfleger AJPfleger deleted the fixing-the-docs branch May 18, 2022 06:55
@paulgessinger paulgessinger modified the milestones: next, v19.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants