Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Unit test geometric digitization hit merging #2213

Merged
merged 9 commits into from Jun 23, 2023
Merged

test: Unit test geometric digitization hit merging #2213

merged 9 commits into from Jun 23, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jun 15, 2023 •
edited

This adds a unit test to the geometric digitization. For now I just added a quick check if that hit merging does something if you provide the same hit twice.

@andiwand andiwand added the 🚧 WIP Work-in-progress label Jun 15, 2023
@andiwand andiwand added this to the next milestone Jun 15, 2023
@andiwand andiwand marked this pull request as ready for review June 19, 2023 15:47
@andiwand andiwand added Component - Examples Affects the Examples module and removed 🚧 WIP Work-in-progress labels Jun 19, 2023
@github-actions github-actions bot removed the Component - Examples Affects the Examples module label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited

Codecov Report

Merging #2213 (bfff96a) into main (9c50e11) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   49.35%   49.35%           
=======================================
  Files         445      445           
  Lines       25263    25263           
  Branches    11650    11650           
=======================================
  Hits        12468    12468           
  Misses       4511     4511           
  Partials     8284     8284

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand @AJPfleger
Update Tests/UnitTests/Examples/Algorithms/Digitization/ModuleCluster…
a61b276 
…sTests.cpp

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
benjaminhuth
benjaminhuth approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to ignore the one comment!

Tests/UnitTests/Examples/Algorithms/Digitization/ModuleClustersTests.cpp Outdated Show resolved Hide resolved
@andiwand andiwand added the Component - Examples Affects the Examples module label Jun 21, 2023
@github-actions github-actions bot removed the Component - Examples Affects the Examples module label Jun 21, 2023
@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited

📊 Physics performance monitoring for bfff96a

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand added the Component - Examples Affects the Examples module label Jun 23, 2023
@github-actions github-actions bot removed the Component - Examples Affects the Examples module label Jun 23, 2023
@andiwand andiwand added the Component - Examples Affects the Examples module label Jun 23, 2023
@github-actions github-actions bot removed the Component - Examples Affects the Examples module label Jun 23, 2023
@paulgessinger
Copy link
Member

This test lives in examples because the cluster class is an examples one, right?

Also concerning the label: I think the pattern would have to be updated for this to be recognized as an Examples change

@andiwand
Copy link
Contributor Author

Not sure if the bot should modify manually added or removed labels. But I guess there are pros and cons about this

@kodiakhq kodiakhq bot merged commit 360b24f into acts-project:main Jun 23, 2023
52 checks passed
@andiwand andiwand deleted the unit-test-geometric-digitization branch June 24, 2023 06:38
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuth benjaminhuth benjaminhuth approved these changes

@AJPfleger AJPfleger AJPfleger left review comments

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v27.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andiwand @paulgessinger @benjaminhuth @AJPfleger