Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add codespell to CI #2218

Merged
merged 14 commits into from Jun 20, 2023
Merged

ci: Add codespell to CI #2218

merged 14 commits into from Jun 20, 2023

Conversation

benjaminhuth
Copy link
Member

This adds a spell checking tool to the CI along with a lot of fixes.

@benjaminhuth benjaminhuth added Infrastructure Changes to build tools, continous integration, ... 🚧 WIP Work-in-progress labels Jun 19, 2023
@benjaminhuth benjaminhuth added this to the next milestone Jun 19, 2023
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2218 (3f72618) into main (c37d881) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   49.36%   49.36%           
=======================================
  Files         445      445           
  Lines       25259    25259           
  Branches    11646    11646           
=======================================
  Hits        12468    12468           
  Misses       4511     4511           
  Partials     8280     8280           
Impacted Files Coverage Δ
.../AmbiguityResolution/GreedyAmbiguityResolution.hpp 0.00% <ø> (ø)
...ore/include/Acts/Clusterization/Clusterization.hpp 100.00% <ø> (ø)
Core/include/Acts/Definitions/Direction.hpp 90.24% <ø> (ø)
Core/include/Acts/Definitions/Units.hpp 100.00% <ø> (ø)
...lude/Acts/Detector/CylindricalContainerBuilder.hpp 100.00% <ø> (ø)
Core/include/Acts/Detector/DetectorBuilder.hpp 100.00% <ø> (ø)
Core/include/Acts/Detector/DetectorVolume.hpp 74.28% <ø> (ø)
...re/include/Acts/Detector/DetectorVolumeBuilder.hpp 100.00% <ø> (ø)
Core/include/Acts/Detector/KdtSurfacesProvider.hpp 57.50% <ø> (ø)
...re/include/Acts/Detector/LayerStructureBuilder.hpp 100.00% <ø> (ø)
... and 171 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

📊 Physics performance monitoring for 3f72618

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. maybe @paulgessinger wants to take a look before we merge

@paulgessinger
Copy link
Member

Could be a good idea. Did you check this for false hits?

@paulgessinger
Copy link
Member

Also: could we get the FPE PR in before this one?

@AJPfleger AJPfleger self-requested a review June 19, 2023 15:36
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added dThe to the ignore list.

Do we need to mark this PR as breaking since auxiliary may be part of the python API?

CI/check_spelling Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/CylinderVolumeBounds.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/AtlasStepper.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/AtlasStepper.hpp Show resolved Hide resolved
Core/include/Acts/Propagator/AtlasStepper.hpp Outdated Show resolved Hide resolved
CI/codespell_ignore.txt Show resolved Hide resolved
benjaminhuth and others added 3 commits June 19, 2023 22:15
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@benjaminhuth
Copy link
Member Author

Do we need to mark this PR as breaking since auxiliary may be part of the python API?

The python API is not subject of our versioning I think.

@kodiakhq kodiakhq bot merged commit cd0693b into acts-project:main Jun 20, 2023
52 checks passed
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants