Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: qOverP and absoluteMomentum for Stepper interface #2253

Merged

Conversation

andiwand
Copy link
Contributor

With this PR I try to align the naming in the Stepper interface to qOverP and absoluteMomentum which is also my goal for the track parameters.

I pulled these changes out of #2181.

@andiwand andiwand added the Component - Core Affects the Core module label Jun 30, 2023
@andiwand andiwand added this to the next milestone Jun 30, 2023
@github-actions github-actions bot added Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Track Fitting labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2253 (04f2365) into main (7b0e2ed) will increase coverage by 0.00%.
The diff coverage is 65.85%.

@@           Coverage Diff           @@
##             main    #2253   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         449      449           
  Lines       25405    25408    +3     
  Branches    11724    11724           
=======================================
+ Hits        12518    12521    +3     
  Misses       4554     4554           
  Partials     8333     8333           
Impacted Files Coverage Δ
Core/include/Acts/Navigation/NextNavigator.hpp 47.65% <0.00%> (ø)
Core/include/Acts/Propagator/StandardAborters.hpp 68.62% <0.00%> (ø)
.../include/Acts/Propagator/detail/LoopProtection.hpp 42.10% <0.00%> (ø)
.../include/Acts/Propagator/detail/SteppingLogger.hpp 46.15% <0.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.05% <ø> (ø)
...Acts/Propagator/detail/GenericDefaultExtension.hpp 33.80% <42.85%> (ø)
...agator/detail/GenericDenseEnvironmentExtension.hpp 53.02% <50.00%> (+0.31%) ⬆️
Core/include/Acts/Propagator/EigenStepper.hpp 75.51% <75.00%> (ø)
...re/include/Acts/Propagator/StraightLineStepper.hpp 74.62% <80.00%> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp 72.02% <85.71%> (+0.03%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger changed the title refactor: qOverP and absoluteMomentum for Stepper interface refactor!: qOverP and absoluteMomentum for Stepper interface Jun 30, 2023
@paulgessinger paulgessinger changed the title refactor!: qOverP and absoluteMomentum for Stepper interface refactor: qOverP and absoluteMomentum for Stepper interface Jun 30, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine from my side.

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

📊 Physics performance monitoring for 04f2365

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger
Copy link
Member

paulgessinger commented Jun 30, 2023

I guess this is also not really breaking if you don't use the Stepper directly?

@andiwand
Copy link
Contributor Author

I guess this is also not really breaking if you don't use the Stepper directly?

Yeah depends on what we view as a public interface. The stepper interface is breaking but it is absorbed by the Propagator for example.

@kodiakhq kodiakhq bot merged commit f22a278 into acts-project:main Jun 30, 2023
52 checks passed
@andiwand andiwand deleted the refactor-stepper-interface-naming branch July 3, 2023 06:44
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants