refactor: AMVF error handling and zt splitting

[felix-russo]

• Throws errors when encountering singular/non positive definite covariance matrices
• Implements splitting in z-t

[codecov]

Codecov Report

Attention: Patch coverage is 11.62791% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 48.63%. Comparing base (fd0e845) to head (112f91d).

Files	Patch %	Lines
Core/src/Vertexing/AdaptiveMultiVertexFinder.cpp	13.51%	18 Missing and 14 partials ⚠️
Core/src/Vertexing/VertexingError.cpp	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
- Coverage   48.67%   48.63%   -0.05%     
==========================================
  Files         493      493              
  Lines       29004    29030      +26     
  Branches    13816    13844      +28     
==========================================
+ Hits        14117    14118       +1     
- Misses       4947     4965      +18     
- Partials     9940     9947       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 112f91d

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[andiwand]

Good stuff! I somehow overlooked that PR.

I worry a bit about the error log statements. Generally I am in favor of these but they backfired in the past because Athena is producing job failures if ACTS logs an error and this is usually not what we want.

We can either hope that they do not pop up or we lower the level a bit

[andiwand]

This also conflicted with the vertexing refactor - do you think you can work on this over the next few days @felix-russo ? If not we can figure out how to follow up on this

[felix-russo]

Thanks for the feedback!

I can work on this next weekend. If that's too late, feel free to reopen your PR or adapt this one; I don't mind which one goes in :)

[andiwand]

resolved the conflicts and incorporated the feedback

[andiwand]

looks like athena is fine with this

[paulgessinger]

The GitLab physmon job fails for some reason that is not obvious to me.

[andiwand]

Looks like this was an FPE that slipped through now. Moved the mask a bit. Let's see if that helps