Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: AMVF do3dSplitting -> doFullSplitting #3004

Merged
merged 4 commits into from
Mar 4, 2024
Merged

refactor!: AMVF do3dSplitting -> doFullSplitting #3004

merged 4 commits into from
Mar 4, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Mar 1, 2024

Pulled this out of #2828 to encapsulate the breaking change

credits @felix-russo

@andiwand andiwand added this to the next milestone Mar 1, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing labels Mar 1, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.67%. Comparing base (6182aef) to head (9ec601d).

Files Patch % Lines
Core/src/Vertexing/AdaptiveMultiVertexFinder.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3004   +/-   ##
=======================================
  Coverage   48.67%   48.67%           
=======================================
  Files         493      493           
  Lines       29004    29004           
  Branches    13816    13816           
=======================================
  Hits        14117    14117           
  Misses       4947     4947           
  Partials     9940     9940

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

📊: Physics performance monitoring for 9ec601d

Full contents

physmon summary

@andiwand @AJPfleger
Update Core/include/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp
e4e8c73 
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@paulgessinger
Copy link
Member

I'd like to run Athena on this before merging.

@acts-project-service
Copy link
Collaborator

acts-project-service commented Mar 4, 2024 •
edited
Loading

🔴 Athena integration test results [4a204ce]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Mar 4, 2024
@paulgessinger
Copy link
Member

paulgessinger commented Mar 4, 2024 •
edited
Loading

This needs a patch or Athena. I'll look into it.

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Mar 4, 2024
@paulgessinger
Copy link
Member

Ok I think Athena is happy.

@andiwand andiwand added automerge and removed Fails Athena tests This PR causes a failure in the Athena tests labels Mar 4, 2024
@kodiakhq kodiakhq bot merged commit 4a204ce into acts-project:main Mar 4, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label Mar 4, 2024
@andiwand andiwand deleted the refactor-amvf-dofullsplitting branch March 4, 2024 15:28
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build and removed Breaks Athena build This PR breaks the Athena build labels Mar 6, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Mar 7, 2024
@andiwand @Ragansu
refactor!: AMVF do3dSplitting -> doFullSplitting (acts-project#3004)
a8424f9 
Pulled this out of acts-project#2828 to encapsulate the breaking change

credits @felix-russo
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@andiwand @EleniXoch
refactor!: AMVF do3dSplitting -> doFullSplitting (acts-project#3004)
648a688 
Pulled this out of acts-project#2828 to encapsulate the breaking change

credits @felix-russo
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@andiwand @asalzburger
refactor!: AMVF do3dSplitting -> doFullSplitting (acts-project#3004)
b9f3acc 
Pulled this out of acts-project#2828 to encapsulate the breaking change

credits @felix-russo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing
Projects
None yet
Milestone
v33.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @paulgessinger @acts-project-service @AJPfleger