refactor: Backport navigation rewrite changes #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
==========================================
- Coverage 47.51% 47.42% -0.09%
==========================================
Files 499 499
Lines 28292 28278 -14
Branches 13832 13831 -1
==========================================
- Hits 13442 13410 -32
- Misses 4970 4989 +19
+ Partials 9880 9879 -1 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 8b80a34physmon summary
|
untemplate nav options fix nav failure for endless bounds intersection maybe more
This was referenced Dec 21, 2023
…port-navigation-rewrite-changes
andiwand
commented
Feb 27, 2024
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
May 25, 2024
In #2846 I removed a constructor parameter which was used by Athena and maybe other clients. This would classify as a breaking change. To work around that I reintroduced the parameter and marked the constructor as deprecated.
acts-project-service
added
the
Fails Athena tests
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
Backporting more changes from acts-project#2625 to main. This is a followup to acts-project#2768 Summary - remove overstepping from steppers - use surface tolerance for geometry lookups - add self consistency navigation test
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
In acts-project#2846 I removed a constructor parameter which was used by Athena and maybe other clients. This would classify as a breaking change. To work around that I reintroduced the parameter and marked the constructor as deprecated.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - #2846 - #2849
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jun 14, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
Backporting more changes from acts-project#2625 to main. This is a followup to acts-project#2768 Summary - remove overstepping from steppers - use surface tolerance for geometry lookups - add self consistency navigation test
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
In acts-project#2846 I removed a constructor parameter which was used by Athena and maybe other clients. This would classify as a breaking change. To work around that I reintroduced the parameter and marked the constructor as deprecated.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR adds a "try all" navigator which can be used as a reference to validate other navigators depends on - acts-project#2846
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
As previously removed by #2846 and then reintroduced in #3223 to keep compatibility, I propose to remove the `overstepLimit` parameter from the `EigenStepper` since it does not have any effect anymore. The propagation still handles overstepping but the hard cutoff parameter is pushed out of the stepper interface. Right now we allow overstepping of any distance. If we need a cutoff value I would suggest putting it into the navigator or propagator.
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
) As previously removed by acts-project#2846 and then reintroduced in acts-project#3223 to keep compatibility, I propose to remove the `overstepLimit` parameter from the `EigenStepper` since it does not have any effect anymore. The propagation still handles overstepping but the hard cutoff parameter is pushed out of the stepper interface. Right now we allow overstepping of any distance. If we need a cutoff value I would suggest putting it into the navigator or propagator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting more changes from #2625 to main. This is a followup to #2768
Summary